[dpdk-dev] [RFC 3/4] net/ixgbe: enable async device reset

Qi Zhang qi.z.zhang at intel.com
Wed Aug 8 09:00:44 CEST 2018


Handle device reset in a separate thread and raise
RTE_ETH_EVENT_RESET_COMPLETE event when it is done.

Signed-off-by: Qi Zhang <qi.z.zhang at intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 48 +++++++++++++++++++++++++++++++---------
 1 file changed, 38 insertions(+), 10 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 26b192737..6e2d6fc1a 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2923,12 +2923,29 @@ ixgbe_dev_close(struct rte_eth_dev *dev)
 	ixgbe_set_rar(hw, 0, hw->mac.addr, 0, IXGBE_RAH_AV);
 }
 
+static void *
+do_dev_reset(void *args)
+{
+	struct rte_eth_dev *dev = args;
+	int ret;
+
+	ret = eth_ixgbe_dev_uninit(dev);
+	if (!ret)
+		ret = eth_ixgbe_dev_init(dev, NULL);
+
+	_rte_eth_dev_callback_process(dev,
+			RTE_ETH_EVENT_RESET_COMPLETE,
+			&ret);
+	return NULL;
+}
+
 /*
  * Reset PF device.
  */
 static int
 ixgbe_dev_reset(struct rte_eth_dev *dev)
 {
+	pthread_t tid;
 	int ret;
 
 	/* When a DPDK PMD PF begin to reset PF port, it should notify all
@@ -2940,11 +2957,8 @@ ixgbe_dev_reset(struct rte_eth_dev *dev)
 	if (dev->data->sriov.active)
 		return -ENOTSUP;
 
-	ret = eth_ixgbe_dev_uninit(dev);
-	if (ret)
-		return ret;
-
-	ret = eth_ixgbe_dev_init(dev, NULL);
+	ret = rte_ctrl_thread_create(&tid, "ixgbe_dev_reset",
+				NULL, do_dev_reset, dev);
 
 	return ret;
 }
@@ -5173,19 +5187,33 @@ ixgbevf_dev_close(struct rte_eth_dev *dev)
 	ixgbevf_remove_mac_addr(dev, 0);
 }
 
+static void *
+do_dev_vf_reset(void *args)
+{
+	struct rte_eth_dev *dev = args;
+	int ret;
+
+	ret = eth_ixgbevf_dev_uninit(dev);
+	if (!ret)
+		ret = eth_ixgbevf_dev_init(dev);
+
+	_rte_eth_dev_callback_process(dev,
+			RTE_ETH_EVENT_RESET_COMPLETE,
+			&ret);
+	return NULL;
+}
+
 /*
  * Reset VF device
  */
 static int
 ixgbevf_dev_reset(struct rte_eth_dev *dev)
 {
+	pthread_t tid;
 	int ret;
 
-	ret = eth_ixgbevf_dev_uninit(dev);
-	if (ret)
-		return ret;
-
-	ret = eth_ixgbevf_dev_init(dev);
+	ret = rte_ctrl_thread_create(&tid, "ixgbevf_dev_reset",
+				NULL, do_dev_vf_reset, dev);
 
 	return ret;
 }
-- 
2.13.6



More information about the dev mailing list