[dpdk-dev] [PATCH v14 5/6] drivers/net: enable device detach on secondary

[Zhang, Qi Z]

> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybchenko at solarflare.com]
> Sent: Sunday, August 12, 2018 6:51 PM
> To: Zhang, Qi Z <qi.z.zhang at intel.com>; thomas at monjalon.net;
> gaetan.rivet at 6wind.com; Burakov, Anatoly <anatoly.burakov at intel.com>
> Cc: Ananyev, Konstantin <konstantin.ananyev at intel.com>; dev at dpdk.org;
> Richardson, Bruce <bruce.richardson at intel.com>; Yigit, Ferruh
> <ferruh.yigit at intel.com>; Shelton, Benjamin H
> <benjamin.h.shelton at intel.com>; Vangati, Narender
> <narender.vangati at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v14 5/6] drivers/net: enable device detach on
> secondary
> 
> On 10.08.2018 03:42, Qi Zhang wrote:
> > With the enabling for hotplug on multi-process, it is not necessary to
> > prevent detaching a device from a secondary process.
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang at intel.com>
> 
>  From the patch itself including description it is absolutely unclear why
> detach works and where it actually happens.

OK, I will add more detail comment.

> Why is it OK to return 0 instead of error and that's it.

Obviously , something need to fix, since uninit is not only called by driver->remove

> Why is it necessary to call uninit at all in the case of secondary processes?

Will parse NULL to rte_eth_dev_pci_generic_remove for secondary process.