[dpdk-dev] [PATCH] kni: fix kni rx fifo producer synchronization
Jerin Jacob
jerin.jacob at caviumnetworks.com
Thu Aug 16 11:01:17 CEST 2018
-----Original Message-----
> Date: Thu, 9 Aug 2018 15:53:53 +0530
> From: Kiran Kumar <kkokkilagadda at caviumnetworks.com>
> To: ferruh.yigit at intel.com
> CC: dev at dpdk.org, Kiran Kumar <kkokkilagadda at caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH] kni: fix kni rx fifo producer synchronization
> X-Mailer: git-send-email 2.7.4
>
> External Email
>
> With existing code in kni_fifo_put, rx_q values are not being updated
> before updating fifo_write. While reading rx_q in kni_net_rx_normal,
> This is causing the sync issue on other core. So adding a write
> barrier to make sure the values being synced before updating fifo_write.
>
> Fixes: 3fc5ca2f6352 ("kni: initial import")
>
Please fix following check patch issue.
Wrong headline lowercase:
kni: fix kni rx fifo producer synchronization
and Cc stable at dpdk.org
With above change:
Acked-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> Signed-off-by: Kiran Kumar <kkokkilagadda at caviumnetworks.com>
> ---
> lib/librte_kni/rte_kni_fifo.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_kni/rte_kni_fifo.h b/lib/librte_kni/rte_kni_fifo.h
> index ac26a8c..4d6b33e 100644
> --- a/lib/librte_kni/rte_kni_fifo.h
> +++ b/lib/librte_kni/rte_kni_fifo.h
> @@ -39,6 +39,7 @@ kni_fifo_put(struct rte_kni_fifo *fifo, void **data, unsigned num)
> fifo->buffer[fifo_write] = data[i];
> fifo_write = new_write;
> }
> + rte_smp_wmb();
> fifo->write = fifo_write;
> return i;
> }
> --
> 2.7.4
>
More information about the dev
mailing list