[dpdk-dev] [PATCH] check-symbol-change: relax rule for identifying a section
Thomas Monjalon
thomas at monjalon.net
Tue Aug 21 11:03:21 CEST 2018
17/08/2018 05:03, Rao, Nikhil:
> On 8/16/2018 4:38 PM, Neil Horman wrote:
> > It was reported recently that some patches that add symbols to an
> > existing EXPERIMENTAL section of a version map file generate errors
> > because the check-symbol-change script was identifying the section as
> > "@@" rather than EXPERIMENTAL. This was fairly clearly due to the fact
> > that the rule identifying the version section expected the whole section
> > to be added, rather than having it already exist, with only new symbols
> > being added to the existing section. This led the match rule to misread
> > the format of that line and pull the wrong word out of it.
> >
> > The fix is to relax the rule slightly. Rather than assume that the
> > section must exist on a line that was added, allow the section name to
> > be set by any line that ends in a '{', which should be correct, given
> > our coding practices. The section name is then extracted as the next to
> > the last word on the line ( $(NF-1) ).
> >
> > Tested by the reporter with good results
> >
> > Reported-by: nikhil.rao at intel.com
> > Signed-off-by: Neil Horman <nhorman at tuxdriver.com>
> >
> Tested-by: Nikhil Rao <nikhil.rao at intel.com>
Applied, thanks
More information about the dev
mailing list