[dpdk-dev] [PATCH v2 05/20] net/ice: support packet type getting

[Lu, Wenzhuo]

Hi Vipin,


> -----Original Message-----
> From: Varghese, Vipin
> Sent: Tuesday, December 4, 2018 1:19 PM
> To: Lu, Wenzhuo <wenzhuo.lu at intel.com>; dev at dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Zhao1, Wei
> <wei.zhao1 at intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2 05/20] net/ice: support packet type
> getting
> 
> snipped
> > +static inline uint32_t
> > +ice_get_default_pkt_type(uint16_t ptype) {
> 
> Suggestion: should we check 'ptype >= RTE_PTYPE_UNKNOWN ' return?
Good suggestion. Will update it in the new version.
> 
> Suggestion: is it ok to use MACRO instead of array.
The array is for a better performance. I don't know the idea of macro. Would you like to give more details? Thanks.

> snipped