[dpdk-dev] [PATCH 1/3] eal: add --dev-hotplug option

David Marchand david.marchand at redhat.com
Mon Dec 17 11:15:45 CET 2018


On Fri, Dec 14, 2018 at 8:41 AM Jeff Guo <jia.guo at intel.com> wrote:

> This command-line option will enable hotplug event detecting and enable
> hotplug handling for device hotplug.
>
> Signed-off-by: Jeff Guo <jia.guo at intel.com>
>

Is there a reason why we would want this disabled by default and enabled
via option ?


diff --git a/lib/librte_eal/common/eal_options.h
> b/lib/librte_eal/common/eal_options.h
> index 5271f94..4d8a12e 100644
> --- a/lib/librte_eal/common/eal_options.h
> +++ b/lib/librte_eal/common/eal_options.h
> @@ -65,7 +65,9 @@ enum {
>         OPT_SINGLE_FILE_SEGMENTS_NUM,
>  #define OPT_IOVA_MODE          "iova-mode"
>         OPT_IOVA_MODE_NUM,
> -       OPT_LONG_MAX_NUM
> +       OPT_LONG_MAX_NUM,
> +#define OPT_DEV_HOTPLUG              "dev-hotplug"
> +       OPT_DEV_HOTPLUG_NUM,
>  };
>
>  extern const char eal_short_options[];
>

OPT_LONG_MAX_NUM is supposed to be the last enum.

-- 
David Marchand


More information about the dev mailing list