[dpdk-dev] [PATCH v8 2/6] Move common functions in eal.c

[Ferruh Yigit]

On 4/29/2015 12:46 AM, rkerur at gmail.com (Ravi Kerur) wrote:
> Changes in v8
> Fix ABI warnings by reordering compilation of
> eal_common_sysfs.c
> eal_common_mem_cfg.c
> eal_common_proc_type.c
> eal_common_app_usage.c
> 
> Changes in v7
> Fix compilation errors in clang.
> 
> Changes in v6
> Split eal_common_system.c and eal_common_runtime.c into
> eal_common_sysfs.c
> eal_common_mem_cfg.c
> eal_common_proc_type.c
> eal_common_app_usage.c
> based on functionality.
> 
> Changes in v5
> Rebase to latest code.
> 
> Changes in v4
> Remove eal_externs.h file, instead use  _get_ and _set_ APIS
> to access those variables.
> Split eal_common.c into eal_common_system.c and
> and eal_common_runtime.c
> rte_eal prefix functions are moved to _runtime_ and
> eal prefix functions are moved to _system_ files respectively.
> 
> Changes in v3
> Changed subject to be more explicit on file name inclusion.
> 
> Changes in v2
> In function rte_eal_config_create remove #ifdef _BSDAPP_
> and initialize mem_cfg_addr unconditionally.
> 
> Changes in v1
> Move common functions in eal.c to librte_eal/common/eal_common.c.
> 
> Following functions are moved to eal_common.c file.
> 
> struct rte_config *rte_eal_get_configuration(void);
> int eal_parse_sysfs_value(const char *filename, unsigned long *val);
> static void rte_eal_config_create(void);
> enum rte_proc_type_t eal_proc_type_detect(void);
> void rte_eal_config_init(void);
> rte_usage_hook_t rte_set_application_usage_hook(rte_usage_hook_t
> usage_func);
> inline size_t eal_get_hugepage_mem_size(void);
> void eal_check_mem_on_local_socket(void);
> int sync_func(__attribute__((unused)) void *arg);
> inline void rte_eal_mcfg_complete(void);
> int rte_eal_has_hugepages(void);
> enum rte_lcore_role_t rte_eal_lcore_role(unsigned lcore_id);
> enum rte_proc_type_t rte_eal_process_type(void);
> 
> Makefile changes to reflect new files added.
> Fix checkpatch warnings and errors.
> 
> Signed-off-by: Ravi Kerur <rkerur at gmail.com>

Hi Ravi,

This patch is sitting on patchwork since 2015, I am updating it as rejected, if
it is still relevant please let us know.

Sorry for any inconvenience caused.