[dpdk-dev] [PATCH / RFC ] ethdev: Allow rte_eth_dev_configure with zero RX/TX queues

Ferruh Yigit ferruh.yigit at intel.com
Fri Dec 21 00:34:42 CET 2018


On 6/23/2016 4:53 PM, thomas.monjalon at 6wind.com (Thomas Monjalon) wrote:
> 2016-05-16 11:33, Simon Kagstrom:
>> This allows releasing RX/TX queue memory.
>> ---
>> We're using DPDK 16.04 and have a test suite which performs a sequence
>> of separate tests of the type
>>
>>    allocate mempool
>>    rte_eth_dev_configure(port, n_rxq, n_txq, ...)
>>    setup rx/tx queues
>>    rte_eth_dev_start(port)
>>
>>    <perform actual test>
>>
>>    stop rx/tx queues
>>    rte_eth_dev_stop(port)
>>
>> -> rte_eth_dev_configure(port, 0, 0, ...)
>>    
>>    check that there are no leaks from the mempool
>>
>> The crucial point is the marked line above. This is done so that the
>> rx_queue_release/tx_queue_release callbacks in the PMD is called, so
>> that mbufs allocated by the driver is released.
> 
> I think you are trying to use a side effect of rte_eth_dev_configure().
> After calling rte_eth_dev_stop(), I would say the clean-up should be done
> by rte_eth_dev_close().
> Why not using close?
> 

Hi Simon,

This patch is in patchwork for a long time without response, updating its status
as rejected, if it is still relevant please let us know.


More information about the dev mailing list