[dpdk-dev] [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API

Hemant Agrawal hemant.agrawal at nxp.com
Fri Feb 2 14:47:26 CET 2018


Hi Olivier,

> On Fri, Feb 02, 2018 at 01:33:01PM +0530, Hemant Agrawal wrote:
> > From: Nipun Gupta <nipun.gupta at nxp.com>
> >
> > The existing rte_eal_mbuf_default mempool ops can return the compile
> > time default ops name if the user has not provided command line inputs
> > for mempool ops name. It will break the logic of best mempool ops as
> > it will never return platform hw mempool ops.
> >
> > This patch introduces a new API to just return the user mempool ops only.
> >
> > Fixes: 8b0f7f434132 ("mbuf: maintain user and compile time mempool ops
> > name")
> >
> > Signed-off-by: Nipun Gupta <nipun.gupta at nxp.com>
> 
> This option is fine for me. I think we may also consider deprecating
> rte_eal_mbuf_default_mempool_ops(), as it is done in option 2.

[Hemant]   Ok. Please also ack following. I will update patchwork for remaining patches accordingly.
	[PATCH v2] doc: remove eal API for default mempool ops name

> Acked-by: Olivier Matz <olivier.matz at 6wind.com>

Thanks
Hemant


More information about the dev mailing list