[dpdk-dev] [PATCH] compressdev: implement API
Thomas Monjalon
thomas at monjalon.net
Sun Feb 4 15:24:40 CET 2018
02/02/2018 19:25, Fiona Trahe:
> config/common_base | 6 +
> doc/api/doxy-api-index.md | 1 +
> doc/api/doxy-api.conf | 1 +
> lib/Makefile | 3 +
> lib/librte_compressdev/Makefile | 29 +
> lib/librte_compressdev/rte_comp.h | 503 ++++++++++++
Why rte_comp.h instead of the more consistent rte_compress.h?
> lib/librte_compressdev/rte_compressdev.c | 902 +++++++++++++++++++++
> lib/librte_compressdev/rte_compressdev.h | 757 +++++++++++++++++
> lib/librte_compressdev/rte_compressdev_pmd.c | 163 ++++
> lib/librte_compressdev/rte_compressdev_pmd.h | 439 ++++++++++
> lib/librte_compressdev/rte_compressdev_version.map | 47 ++
> lib/librte_eal/common/include/rte_log.h | 1 +
> mk/rte.app.mk | 1 +
> 13 files changed, 2853 insertions(+)
Please update MAINTAINERS file and release notes.
Maybe it is worth splitting this patch in few shorter parts?
> --- a/config/common_base
> +++ b/config/common_base
> @@ -535,6 +535,12 @@ CONFIG_RTE_LIBRTE_PMD_MRVL_CRYPTO=n
> CONFIG_RTE_LIBRTE_PMD_MRVL_CRYPTO_DEBUG=n
>
> #
> +# Compile generic compression device library
> +#
> +CONFIG_RTE_LIBRTE_COMPRESSDEV=y
> +CONFIG_RTE_COMPRESS_MAX_DEVS=64
> +
> +#
> # Compile generic security library
> #
> CONFIG_RTE_LIBRTE_SECURITY=y
> diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
> index d77f205..07b8e75 100644
> --- a/doc/api/doxy-api-index.md
> +++ b/doc/api/doxy-api-index.md
> @@ -43,6 +43,7 @@ The public API headers are grouped by topics:
> [rte_tm] (@ref rte_tm.h),
> [rte_mtr] (@ref rte_mtr.h),
> [bbdev] (@ref rte_bbdev.h),
> + [compressdev] (@ref rte_compressdev.h),
> [cryptodev] (@ref rte_cryptodev.h),
> [security] (@ref rte_security.h),
> [eventdev] (@ref rte_eventdev.h),
Please move it between security and eventdev in these lists.
More information about the dev
mailing list