[dpdk-dev] [PATCH v2] ethdev: make ethdev data cache aligned

Jerin Jacob jerin.jacob at caviumnetworks.com
Mon Feb 12 06:54:39 CET 2018


Since struct rte_eth_dev_data used in the fast path,
making it as cache aligned.

Fixes: af75078fece3 ("first public release")
Fixes: 5b7ba31148a8 ("ethdev: add port ownership")

Cc: Matan Azrad <matan at mellanox.com>
Cc: Thomas Monjalon <thomas at monjalon.net>
Cc: Konstantin Ananyev <konstantin.ananyev at intel.com>

Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
Signed-off-by: Pavan Nikhilesh <pbhagavatula at caviumnetworks.com>
---
v2:
- Change the git comments based on Matan's feedback
https://dpdk.org/dev/patchwork/patch/35104/

- Some platform like thunderx + l3fwd showed 1% regression in
the performance with 5b7ba31148a8 ("ethdev: add port ownership")
in one port setup.

- If there are no objection for this change then request to
take it for v18.02 release.
---
 lib/librte_ether/rte_ethdev_core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_ether/rte_ethdev_core.h b/lib/librte_ether/rte_ethdev_core.h
index 315b31723..e5681e466 100644
--- a/lib/librte_ether/rte_ethdev_core.h
+++ b/lib/librte_ether/rte_ethdev_core.h
@@ -601,7 +601,7 @@ struct rte_eth_dev_data {
 	struct rte_vlan_filter_conf vlan_filter_conf;
 	/**< VLAN filter configuration. */
 	struct rte_eth_dev_owner owner; /**< The port owner. */
-};
+} __rte_cache_aligned;
 
 /**
  * @internal
-- 
2.16.1



More information about the dev mailing list