[dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build

[Matan Azrad]

> -----Original Message-----
> From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch at intel.com]
> Sent: Wednesday, February 14, 2018 12:19 AM
> To: Thomas Monjalon <thomas at monjalon.net>; Matan Azrad
> <matan at mellanox.com>
> Cc: dev at dpdk.org; gaetan.rivet at 6wind.com
> Subject: RE: [dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> > Sent: Tuesday, February 13, 2018 10:13 PM
> > To: matan at mellanox.com
> > Cc: dev at dpdk.org; gaetan.rivet at 6wind.com
> > Subject: [dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build
> >
> > The type pthread_t is not portable because it is freely defined.
> > On Linux, it is an unsigned long int which can be printed with %l.
> > On FreeBSD, it is a pointer which can be printed with %p.
> >
> > That's why there was this error:
> > drivers/net/failsafe/failsafe_private.h:377:53: error:
> > 	format specifies type 'unsigned long' but the argument has
> > 	type 'pthread_t' (aka 'struct pthread *')
> >
> > Fixes: 655fcd68c7d2 ("net/failsafe: fix hotplug races")
> >
> > Reported-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
> > Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> 
> Tested-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
> 
Acked-by: Matan Azrad <matan at mellanox.com>