[dpdk-dev] [PATCH] app/pdump: check for ports

[Varghese, Vipin]

> -----Original Message-----
> From: Pattan, Reshma
> Sent: Monday, February 26, 2018 11:02 AM
> To: Varghese, Vipin <vipin.varghese at intel.com>; dev at dpdk.org
> Cc: Mcnamara, John <john.mcnamara at intel.com>
> Subject: RE: [PATCH] app/pdump: check for ports
> 
> 
> 
> > -----Original Message-----
> > From: Varghese, Vipin
> > Sent: Monday, February 26, 2018 4:30 PM
> > To: dev at dpdk.org; Pattan, Reshma <reshma.pattan at intel.com>
> > Cc: Mcnamara, John <john.mcnamara at intel.com>; Varghese, Vipin
> > <vipin.varghese at intel.com>
> > Subject: [PATCH] app/pdump: check for ports
> >

<snipped>

> > +	if (rte_eth_dev_count() == 0)
> > +		rte_exit(EXIT_FAILURE, "Failed to fetch ports for
> PDUMP!\n");
> > +
> 
> Good one, can you just change the failure log to rte_exit(EXIT_FAILURE, "No
> Ethernet ports - bye\n"); As, I see most of the other examples and apps do
> use the similar check and log as above. :-)
> 

Sure, I will send a v2 patch with updated log information.

> Thanks,
> Reshma