[dpdk-dev] [PATCH] ethdev: fix link autonegotiation value

[Stephen Hemminger]

On Fri,  5 Jan 2018 18:38:55 +0100
Thomas Monjalon <thomas at monjalon.net> wrote:

> There are 3 kind of link data in ethdev:
> 	- capabilities (rte_eth_dev_info)
> 	- configuration (rte_eth_conf)
> 	- status (rte_eth_link)
> 
> A bit-field is used for capabilities (rte_eth_dev_info.speed_capa) and
> configuration (rte_eth_conf.link_speeds).
> Bits are defined in ETH_LINK_SPEED_*.
> 
> Some numerical (ETH_SPEED_NUM_*) and boolean (ETH_LINK_*) values
> are used for the link status (rte_eth_link.*).
> 
> There was a mistake in the comment of rte_eth_link.link_autoneg,
> suggesting ETH_LINK_SPEED_[AUTONEG/FIXED] which are 0/1,
> instead of ETH_LINK_[AUTONEG/FIXED] which are 1/0.
> 
> The drivers are fixed to use ETH_LINK_[AUTONEG/FIXED].
> 
> Fixes: 82113036e4e5 ("ethdev: redesign link speed config")
> 
> Suggested-by: Andrew Rybchenko <arybchenko at solarflare.com>
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>

Thanks for clearing this up.

Acked-by: Stephen Hemminger <stephen at networkplumber.org>