[dpdk-dev] [PATCH 9/9] tools: use SPDX tag for Cavium copyright files

[Jerin Jacob]

-----Original Message-----
> Date: Sun, 7 Jan 2018 14:24:11 +0530
> From: Hemant Agrawal <hemant.agrawal at nxp.com>
> To: Jerin Jacob <jerin.jacob at caviumnetworks.com>, dev at dpdk.org
> CC: thomas at monjalon.net
> Subject: Re: [PATCH 9/9] tools: use SPDX tag for Cavium copyright files
> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
>  Thunderbird/45.8.0
> 
> On 1/6/2018 5:50 PM, Jerin Jacob wrote:
> > Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> > ---
> >  devtools/build-tags.sh | 30 ++----------------------------
> >  1 file changed, 2 insertions(+), 28 deletions(-)
> > 
> > diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
> > index 942da2bae..d775b17e9 100755
> > --- a/devtools/build-tags.sh
> > +++ b/devtools/build-tags.sh
> > @@ -1,35 +1,9 @@
> >  #!/bin/sh -e
> >  # Generate tags or gtags or cscope or etags files
> >  #
> > -#   BSD LICENSE
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright(c) 2017 Cavium, Inc
> 
> Hi Jerin,
>        All your patches are ok except this one.
> It is not aligned with the policy.
> SPDX tag shall be in 1st or 2nd line (for !/bin/sh) scripts.
> 
> you can move the comments ("Generate tags...") after the copyrights.

Thanks Hemant. I will move the comments and send the v2.

> 
> Regards,
> Hemant