[dpdk-dev] [PATCH v3 08/10] app/testpmd: remove txqflags

[Lu, Wenzhuo]

Hi Shahaf,

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Tuesday, December 26, 2017 5:44 PM
> To: Wu, Jingjing <jingjing.wu at intel.com>; Yigit, Ferruh
> <ferruh.yigit at intel.com>
> Cc: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v3 08/10] app/testpmd: remove txqflags
> 
> Since testpmd is now using the new Ethdev offloads API and there is a way
> configure each of the tx offloads from CLI or command line, there is no need
> for the txqflags configuration anymore.
> 
> Signed-off-by: Shahaf Shuler <shahafs at mellanox.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro at 6wind.com>


> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 806548196..91dcb31c0 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -259,11 +259,6 @@ int16_t tx_free_thresh = RTE_PMD_PARAM_UNSET;
> int16_t tx_rs_thresh = RTE_PMD_PARAM_UNSET;
> 
>  /*
> - * Configurable value of TX queue flags.
> - */
> -int32_t txq_flags = RTE_PMD_PARAM_UNSET;
> -
> -/*
>   * Receive Side Scaling (RSS) configuration.
>   */
>  uint64_t rss_hf = ETH_RSS_IP; /* RSS IP by default. */ @@ -2084,9 +2079,6
> @@ rxtx_port_config(struct rte_port *port)
> 
>  	if (tx_free_thresh != RTE_PMD_PARAM_UNSET)
>  		port->tx_conf.tx_free_thresh = tx_free_thresh;
> -
> -	if (txq_flags != RTE_PMD_PARAM_UNSET)
> -		port->tx_conf.txq_flags = txq_flags;
I think we have some problem if just remove this code. Because port->tx_conf.txq_flags is used by many NICs. If txqflags is removed, all these NICs have to use the default value and have no chance to change it.  I think it's a good idea to use tx-offloads to replace txqflags, but we may need to clear the drivers' code first.