[dpdk-dev] [PATCH v3 10/10] app/testpmd: fix on the flight VLAN configuration

Shahaf Shuler shahafs at mellanox.com
Tue Jan 9 11:03:43 CET 2018


Tuesday, January 9, 2018 10:06 AM, Lu, Wenzhuo:
> > Subject: [dpdk-dev] [PATCH v3 10/10] app/testpmd: fix on the flight
> > VLAN configuration
> >
> > On ethdev there is an API to configure VLAN offloads after the port
> > was started and without reconfiguration of the port or queues.
> >
> > In the current design of the application, when the Rx offloads are
> > changed (through "port config all" CLI command) the port configuration
> > is overwritten, therefore the configuration made for the VLAN is lost.
> >
> > This patch is to address the issue by a configuration of each port Rx
> > offloads separately instead of using the global Rx config.
> >
> > Fixes: 6dbb2b336586 ("app/testpmd: convert to new Ethdev Rx offloads
> > API")
> This patch is not applied yet. The number 6dbb2b336586 could be
> meaningless. If the previous patch need to be fixed, may I suggest just
> merge this one to that? Or this patch fixes some older issues actually?

Well, this was done per Ferruh's request to better split the patches.

I can merge it with the Rx one, agreed? 


More information about the dev mailing list