[dpdk-dev] [PATCH] event/sw: remove stale IQ references when reconfigured

Jerin Jacob jerin.jacob at caviumnetworks.com
Wed Jan 10 20:00:07 CET 2018


-----Original Message-----
> Date: Wed, 10 Jan 2018 15:56:16 +0530
> From: Pavan Nikhilesh <pbhagavatula at caviumnetworks.com>
> To: Gage Eads <gage.eads at intel.com>, jerin.jacob at caviumnetworks.com,
>  harry.van.haaren at intel.com, santosh.shukla at caviumnetworks.com
> Cc: dev at dpdk.org
> Subject: Re: [PATCH] event/sw: remove stale IQ references when reconfigured
> User-Agent: NeoMutt/20170609 (1.8.3)
> 
> On Tue, Jan 09, 2018 at 10:19:35AM -0600, Gage Eads wrote:
> > This commit fixes a bug in which, when the sw PMD is reconfigured, it would
> > leave stale IQ chunk pointers in each queue's IQ structure. Now, the PMD
> > initializes all IQs at eventdev start time and releases all IQ chunk
> > pointers at eventdev stop time (which has the consequence that any events
> > in a queue when the eventdev is stopped will be lost). This approach should
> > be resilient to any reconfiguration done between the stop and start, such
> > as adding or removing queues.
> >
> > This commit also fixes two potential issues in iq_chunk.h. iq_init()
> > now initializes the IQ's count field to 0, and iq_dequeue_burst() sets
> > iq->head to the appropriate next pointer.
> >
> > Fixes: 5b5e476e59a4 ("event/sw: use dynamically-sized IQs")
> > Signed-off-by: Gage Eads <gage.eads at intel.com>
> Sw eventdev works well alongside Rx adapter now.
> 
> Cheers,
> Pavan.
> 
> Acked-by: Pavan Nikhilesh <pbhagavatula at caviumnetworks.com>

Applied to dpdk-next-eventdev/master. Thanks.


More information about the dev mailing list