[dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD

Lu, Wenzhuo wenzhuo.lu at intel.com
Thu Jan 11 05:52:21 CET 2018


Hi Stephen,


> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Thursday, January 11, 2018 1:18 AM
> To: Lu, Wenzhuo <wenzhuo.lu at intel.com>
> Cc: dev at dpdk.org; Wu, Jingjing <jingjing.wu at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD
> 
> On Wed, 10 Jan 2018 14:15:49 +0800
> Wenzhuo Lu <wenzhuo.lu at intel.com> wrote:
> 
> > +/* spinlock func for base code */
> > +void
> > +avf_init_spinlock_d(struct avf_spinlock *sp) {
> > +	rte_spinlock_init(&sp->spinlock);
> > +}
> > +
> > +void
> > +avf_acquire_spinlock_d(struct avf_spinlock *sp) {
> > +	rte_spinlock_lock(&sp->spinlock);
> > +}
> > +
> > +void
> > +avf_release_spinlock_d(struct avf_spinlock *sp) {
> > +	rte_spinlock_unlock(&sp->spinlock);
> > +}
> > +
> > +void
> > +avf_destroy_spinlock_d(__rte_unused struct avf_spinlock *sp) { }
> 
> You might want to inline these (in a header file) if in critical path.
Thanks for the comments. Will send a patch for it.

Hi Ferruh,
The same question. I'll send a patch base on next-net to change it. If it's not OK and I need to rework the whole patch set, please let me know. Thanks.


More information about the dev mailing list