[dpdk-dev] [PATCH v3 04/15] net/vmxnet3: use rte_eth_linkstatus_set

Ferruh Yigit ferruh.yigit at intel.com
Thu Jan 11 18:02:43 CET 2018


On 1/8/2018 5:45 PM, Stephen Hemminger wrote:
> Use new _rte_eth_link_update helper.
> Also remove no longer necessary include of rte_atomic.h
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>

<...>

> @@ -1130,25 +1079,21 @@ __vmxnet3_dev_link_update(struct rte_eth_dev *dev,
>  			  __rte_unused int wait_to_complete)
>  {
>  	struct vmxnet3_hw *hw = dev->data->dev_private;
> -	struct rte_eth_link old = { 0 }, link;
> +	struct rte_eth_link link = {
> +		.link_speed = ETH_SPEED_NUM_10G,
> +		.link_duplex = ETH_LINK_FULL_DUPLEX,
> +		.link_autoneg = ETH_LINK_SPEED_FIXED,
> +		.link_status = ETH_LINK_DOWN,

Link status before this patch was "ETH_LINK_UP", this is changing it to
"ETH_LINK_DOWN", intentional?

> +	};
>  	uint32_t ret;
>  
> -	memset(&link, 0, sizeof(link));
> -	vmxnet3_dev_atomic_read_link_status(dev, &old);
> -
>  	VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_LINK);
>  	ret = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD);
>  
> -	if (ret & 0x1) {
> +	if (ret & 0x1)
>  		link.link_status = ETH_LINK_UP;
> -		link.link_duplex = ETH_LINK_FULL_DUPLEX;
> -		link.link_speed = ETH_SPEED_NUM_10G;
> -		link.link_autoneg = ETH_LINK_SPEED_FIXED;
> -	}
> -
> -	vmxnet3_dev_atomic_write_link_status(dev, &link);
>  
> -	return (old.link_status == link.link_status) ? -1 : 0;
> +	return _rte_eth_linkstatus_set(dev, &link);
>  }
>  
>  static int
> 



More information about the dev mailing list