[dpdk-dev] [PATCH 2/3] net/ixgbe: implemented security session get size

Radu Nicolau radu.nicolau at intel.com
Mon Jan 15 11:27:14 CET 2018



On 1/8/2018 10:15 AM, De Lara Guarch, Pablo wrote:
>
>> -----Original Message-----
>> From: Nicolau, Radu
>> Sent: Tuesday, December 12, 2017 12:50 PM
>> To: dev at dpdk.org
>> Cc: Ananyev, Konstantin <konstantin.ananyev at intel.com>; Yigit, Ferruh
>> <ferruh.yigit at intel.com>; Gonzalez Monroy, Sergio
>> <sergio.gonzalez.monroy at intel.com>; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch at intel.com>; Doherty, Declan
>> <declan.doherty at intel.com>; akhil.goyal at nxp.com; Nicolau, Radu
>> <radu.nicolau at intel.com>
>> Subject: [PATCH 2/3] net/ixgbe: implemented security session get size
> Use "implement" in infinitive.
>
>> Signed-off-by: Radu Nicolau <radu.nicolau at intel.com>
>> ---
>>   drivers/net/ixgbe/ixgbe_ipsec.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c
>> b/drivers/net/ixgbe/ixgbe_ipsec.c index 105da11..720d6a1 100644
>> --- a/drivers/net/ixgbe/ixgbe_ipsec.c
>> +++ b/drivers/net/ixgbe/ixgbe_ipsec.c
>> @@ -446,6 +446,12 @@ ixgbe_crypto_create_session(void *device,  }
>>
>>   static int
>
>> +ixgbe_crypto_session_get_size(__rte_unused void *device) {
> Do you think passing device to the function prototype is needed?
> Are you expecting other drivers to use it?
I added for consistency with cryptodev.
>
> Also, move the braces to a new line (both opening and ending).
They are correctly formatted on the patch itself.
>
>
>> +	return sizeof(struct ixgbe_crypto_session); }
>> +
> Thanks,
> Pablo
>



More information about the dev mailing list