[dpdk-dev] [PATCH 1/2] net: fix ESP header byte ordering definition

Nélio Laranjeiro nelio.laranjeiro at 6wind.com
Tue Jan 16 16:52:01 CET 2018


On Tue, Jan 16, 2018 at 03:24:09PM +0100, Olivier Matz wrote:
> On Thu, Jan 11, 2018 at 10:15:58AM +0100, Nelio Laranjeiro wrote:
> > ESP header is defined in the RFC2406 [1] as Big Endian fields it should use
> > the corresponding types in DPDK as well.
> > 
> > Fixes: d4b684f7197a ("net: add ESP header to generic flow steering")
> 
> I wonder if we should really mark this as a fix.

I also agree, the point is some examples application have started using
it as CPU order instead of Network order, this patch also needs to be
applied in stable branch before fixing the code using it.

> > Cc: borisp at mellanox.com
> > 
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro at 6wind.com>
> > 
> > [1] https://tools.ietf.org/html/rfc2406
> 
> Acked-by: Olivier Matz <olivier.matz at 6wind.com>

-- 
Nélio Laranjeiro
6WIND


More information about the dev mailing list