[dpdk-dev] [PATCH v8 2/3] eal: add u64 bit variant for reciprocal

[Hemant Agrawal]

Hi Pavan,
     I am bit late in checking it. (series is already applied)

Just few legal queries.

 > --- a/lib/librte_eal/common/rte_reciprocal.c > +++ 
b/lib/librte_eal/common/rte_reciprocal.c
 > @@ -1,3 +1,6 @@
 > +/* SPDX-License-Identifier: BSD-3-Clause
 > + * Copyright(c) 2017 Cavium, Inc

you have added Cavium's copyright here.

 > +
 > +/*
 > + * Code taken from Hacker's Delight:
 > + * http://www.hackersdelight.org/hdcodetxt/divlu.c.txt
 > + * License permits inclusion here per:
 > + * http://www.hackersdelight.org/permissions.htm
 > + */

Did you clarify it Cavium's legal team?

The permissions states that you should not add it to another publication 
without written permission. DPDK can be considered a publication.
Did you got written permission?

If not please specify Cavium's legal team opinion or take permission 
from author. I believe that it is easy to obtain permission for this code.

 >>>>>>
"You are free to use, copy, and distribute any of the code on this web 
site, whether modified by you or not. You need not give attribution. 
This includes the algorithms (some of which appear in Hacker's Delight), 
the Hacker's Assistant, and any code submitted by readers. Submitters 
implicitly agree to this.

*The textural material and pictures are copyright by the author, and the 
usual copyright rules apply. E.g., you may store the material on your 
computer and make hard or soft copies for your own use. However, you may 
not incorporate this material into another publication without written 
permission from the author (which the author may give by email).*

The author has taken care in the preparation of this material, but makes 
no expressed or implied warranty of any kind and assumes no 
responsibility for errors or omissions. No liability is assumed for 
incidental or consequential damages in connection with or arising out of 
the use of the information or programs contained herein."
 >>>>>>>>>
regards,
Hemant