[dpdk-dev] [PATCH] examples/bbdev: fix unchecked return value

Amr Mokhtar amr.mokhtar at intel.com
Wed Jan 31 15:40:25 CET 2018


Added a check on rte_bbdev_stats_get() return before
printing out the statistics results.

Coverity issue: 257018
Fixes: 1ffee690eaa1 ("examples/bbdev: add sample app")

Signed-off-by: Amr Mokhtar <amr.mokhtar at intel.com>
---
 examples/bbdev_app/main.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c
index 2e5bd8c..2af3562 100644
--- a/examples/bbdev_app/main.c
+++ b/examples/bbdev_app/main.c
@@ -609,8 +609,16 @@ print_stats(struct stats_lcore_params *stats_lcore)
 					xstats[i].value);
 	}
 
+	ret = rte_bbdev_stats_get(bbdev_id, &bbstats);
+	if (ret < 0) {
+		free(xstats);
+		free(xstats_names);
+		rte_exit(EXIT_FAILURE,
+				"ERROR(%d): Failure to get BBDEV %u statistics\n",
+				ret, bbdev_id);
+	}
+
 	printf("\nBBDEV STATISTICS:\n=================\n");
-	rte_bbdev_stats_get(bbdev_id, &bbstats);
 	printf("BBDEV %u: %s enqueue count:\t\t%"PRIu64"\n",
 			bbdev_id, stats_border,
 			bbstats.enqueued_count);
-- 
2.7.4



More information about the dev mailing list