[dpdk-dev] [PATCH v3 13/16] cryptodev: replace mbuf scatter gather flag

[De Lara Guarch, Pablo]

Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal at nxp.com]
> Sent: Wednesday, July 4, 2018 1:57 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Doherty, Declan
> <declan.doherty at intel.com>; shally.verma at caviumnetworks.com;
> ravi1.kumar at amd.com; jerin.jacob at caviumnetworks.com; Zhang, Roy Fan
> <roy.fan.zhang at intel.com>; Trahe, Fiona <fiona.trahe at intel.com>;
> tdu at semihalf.com; jianjay.zhou at huawei.com
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 13/16] cryptodev: replace mbuf scatter
> gather flag
> 
> Hi Pablo,
> 
> On 6/28/2018 6:23 AM, Pablo de Lara wrote:
> 
> > The current mbuf scatter gatter feature flag is too ambiguous, as it
> > is not clear if input and/or output buffers can be scatter gather
> > mbufs or not, plus if in-place and/or out-of-place is supported.
> >
> > Therefore, five new flags will replace this flag:
> > - RTE_CRYPTODEV_FF_IN_PLACE_SGL
> > - RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT
> > - RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT
> > - RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT
> > - RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT
> 
> It is better to have OOP instead of OUT_OF_PLACE and IP for INPLACE?
> 
> I guess RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT is supported in
> most of the drivers which support OOP,  I can see some of them are missing.

Thanks for the comments. I will replace OUT_OF_PLACE with OOP,
but I would prefer leaving IN_PLACE, instead of IP, as IP would be confusing
(Internet Protocol comes to mind immediately).

Thanks,
Pablo