[dpdk-dev] [dpdk-stable] [PATCH v3 1/2] memalloc: do not leave unmapped holes in EAL virtual memory area
Thomas Monjalon
thomas at monjalon.net
Thu Jul 12 23:42:19 CEST 2018
01/06/2018 17:06, Burakov, Anatoly:
> On 01-Jun-18 1:59 PM, Dariusz Stojaczyk wrote:
> > EAL reserves a huge area in virtual address space
> > to provide virtual address contiguity for e.g.
> > future memory extensions (memory hotplug). During
> > memory hotplug, if the hugepage mmap succeeds but
> > doesn't suffice EAL's requiriments, the EAL would
> > unmap this mapping straight away, leaving a hole in
> > its virtual memory area and making it available
> > to everyone. As EAL still thinks it owns the entire
> > region, it may try to mmap it later with MAP_FIXED,
> > possibly overriding a user's mapping that was made
> > in the meantime.
> >
> > This patch ensures each hole is mapped back by EAL,
> > so that it won't be available to anyone else.
> >
> > Changes from v2:
> > * replaced rte_panic() with a CRIT log.
> > * added "git fixline" tags
> >
> > Changes from v1:
> > * checkpatch fixes
> >
> > Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime")
> > Cc: anatoly.burakov at intel.com
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk at intel.com>
> > ---
>
> Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>
>
> Thomas, could you please fix the commit message on apply?
Yes
Applied, thanks
More information about the dev
mailing list