[dpdk-dev] [PATCH] test: fix incorrect return types

Burakov, Anatoly anatoly.burakov at intel.com
Tue Jul 17 11:28:28 CEST 2018


On 16-Jul-18 5:58 PM, Reshma Pattan wrote:
> UTs should return either TEST_SUCCESS or TEST_FAILED only.
> They should not return 0, -1 and any other value.
> 
> Fixes: 9c9befea4f ("test: add flow classify unit tests")
> CC: jasvinder.singh at intel.com
> CC: bernard.iremonger at intel.com
> CC: stable at dpdk.org
> 
> Signed-off-by: Reshma Pattan <reshma.pattan at intel.com>
> ---

Perhaps it should be highlighted that along with making them return 
TEST_SUCCESS/FAILURE, you're also fixing the -ENOMEM return in one of 
the code paths.

Otherwise,

Reviewed-by: Anatoly Burakov <anatoly.burakov at intel.com>

-- 
Thanks,
Anatoly


More information about the dev mailing list