[dpdk-dev] [PATCH] app/testpmd: workaround softnic CLI modifications

Dumitrescu, Cristian cristian.dumitrescu at intel.com
Tue Jul 24 19:39:19 CEST 2018



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Moti Haimovsky
> Sent: Tuesday, July 24, 2018 5:21 PM
> To: thomas at monjalon.net
> Cc: dev at dpdk.org; stable at dpdk.org; Moti Haimovsky
> <motih at mellanox.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: workaround softnic CLI
> modifications
> 
> This patch returns the previous testpmd command line handling
> routines (namely cmdline_interact and cmdline_stdin_exit) to the
> prompt routine in order to overcome testpmd abnormal exit observed on
> several setups.
> These routines will only by used when testpmd is compiled without
> support for RTE_LIBRTE_PMD_SOFTNIC
> 
> Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Moti Haimovsky <motih at mellanox.com>
> ---
>  app/test-pmd/cmdline.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 

We should probably fix the issue in the cmdline library to bring cmdline_poll() on parity with cmdline_interact(), but this is a decent workaround to avoid breaking those automation scripts that rely on Ctrl+D behavior.

Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>



More information about the dev mailing list