[dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix dcb config failure

Thomas Monjalon thomas at monjalon.net
Thu Jul 26 19:18:20 CEST 2018


> > After adding RSS hash offload check, default rss_hf will fail on devices that do
> > not support all bits. This will lead to dcb config failure. The patch fixes this
> > issue by taking rss_hf as a suggested value and only setting bits that the
> > device supports based on rte_eth_dev_get_info.
> > 
> > Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> > Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic
> > class")
> > Cc: stable at dpdk.org
> > 
> > Signed-off-by: Xiaoyun Li <xiaoyun.li at intel.com>
> 
> Acked-by: Bernard Iremonger <bernard.iremonger at intel.com>

NACK

testpmd is a test application for developpers.
It must fail if the PMD cannot support user-requested features.

For other applications, there can be a smooth fallback
if and only if there are appropriate logs.
This is what Ferruh did for examples:
	http://git.dpdk.org/dpdk/commit/?id=4f5701f28bd





More information about the dev mailing list