[dpdk-dev] [dpdk-stable] [PATCH] bus/pci: fix a typo

Mcnamara, John john.mcnamara at intel.com
Thu Jul 26 21:25:22 CEST 2018



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Thursday, July 26, 2018 8:21 PM
> To: Rosen, Rami <rami.rosen at intel.com>
> Cc: stable at dpdk.org; dev at dpdk.org; gaetan.rivet at 6wind.com; Mcnamara, John
> <john.mcnamara at intel.com>
> Subject: Re: [dpdk-stable] [PATCH] bus/pci: fix a typo
> 
> 26/07/2018 20:31, Rami Rosen:
> > This patch fixes a trivial typo in pci_common.c.
> >
> > Signed-off-by: Rami Rosen <rami.rosen at intel.com>
> 
> Fixes: 23eaa9059ec2 ("bus/pci: use given name as generic name")
> Cc: gaetan.rivet at 6wind.com
> 
> > --- a/drivers/bus/pci/pci_common.c
> > +++ b/drivers/bus/pci/pci_common.c
> >  	if (devargs != NULL)
> >  		/* If an rte_devargs exists, the generic rte_device uses the
> > -		 * given name as its namea
> > +		 * given name as its name
> >  		 */
> 
> You can replace the "a" by a dot.
> 
> Applied with above changes, thanks.

Yes. I like to see comments as properly punctuated sentences.
other people have other preferences



More information about the dev mailing list