[dpdk-dev] [PATCH v12] devtools: alert on new instances of rte_panic and rte_exit

[Thomas Monjalon]

26/07/2018 22:57, Arnon Warshavsky:
> > > +     if [ $? -ne 0 ] ; then
> > > +             ret=1
> > > +     fi
> > > +     printf '%s\n' "$report"
> >
> > You are printing the report, no matter of the result? Why?
> > Is it because a warning does not return as an error?
> >
> There is maybe an improvement required here.
> >
> 
> Yes this is indeed the reason.
> Sticking to a simple success/fail in the return value with the price of
> printing an empty string in the case of no-warning seemed better than
> handling multiple (>2) return codes .
> Do you have a preferred way here?

My preference is to return an error if there is a warning.
The script itself must return an error code.

Thank you