[dpdk-dev] [PATCH v5 00/10] Make unit tests great again

Pattan, Reshma reshma.pattan at intel.com
Fri Jul 27 10:36:40 CEST 2018


Hi,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Thursday, July 26, 2018 9:05 PM
> To: Pattan, Reshma <reshma.pattan at intel.com>
> Cc: dev at dpdk.org; Burakov, Anatoly <anatoly.burakov at intel.com>;
> Parthasarathy, JananeeX M <jananeex.m.parthasarathy at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again
> 
> 17/07/2018 18:00, Reshma Pattan:
> > Previously, unit tests were running in groups. There were technical reasons
> why that was the case (mostly having to do with limiting memory), but it was
> hard to maintain and update the autotest script.
> >
> > In 18.05, limiting of memory at DPDK startup was no longer necessary, as
> DPDK allocates memory at runtime as needed. This has the implication that
> the old test grouping can now be retired and replaced with a more sensible
> way of running unit tests (using multiprocessing pool of workers and a queue
> of tests). This patchset accomplishes exactly that.
> >
> > This patchset merges changes done in [1], [2]
> >
> > [1] http://dpdk.org/dev/patchwork/patch/40370/
> > [2] http://patches.dpdk.org/patch/40373/
> >
> > Removed unused and duplicate make rules for test-basic, test-mempool,
> > test-ring from make file system in patch 10/10.
> >
> > v4: Removed unused and duplicate make rules for test-basic,
> > test-mempool, test-ring from make file system in patch 10/10.
> >
> > Reshma Pattan (10):
> >   autotest: fix printing
> >   autotest: fix invalid code on reports
> >   autotest: make autotest runner python 2/3 compliant
> >   autotest: visually separate different test categories
> >   autotest: improve filtering
> >   autotest: remove autotest grouping
> >   autotest: properly parallelize unit tests
> >   autotest: update autotest test case list
> >   mk: update make targets for classified testcases
> >   mk: remove unnecessary make rules of test
> 
> Patches 1 to 7 are from Anatoly.
> Patches 8 and 9 were initiated by Jananee.

The respective patches have i.e 1 to 7 have Anatolys Signed--off
And 8 and 9 have Jananees Signed-off along with mine. 

I have used git-am. What I am missing here?

Thanks,
Reshma



More information about the dev mailing list