[dpdk-dev] [PATCH] net/mlx4: Avoid stripping the glue library

[Christian Ehrhardt]

On Tue, Jul 31, 2018 at 3:26 PM Timothy Redaelli <tredaelli at redhat.com>
wrote:

> Stripping binaries at build time is usually a bad thing since it makes
> impossible to generate (split) debug symbols and this can lead to a more
> difficult debugging.
>
> CC: Adrien Mazarguil <adrien.mazarguil at 6wind.com>
> Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in")
>
> Signed-off-by: Timothy Redaelli <tredaelli at redhat.com>
> ---
>  drivers/net/mlx4/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile
> index 63bc00337..92e932250 100644
> --- a/drivers/net/mlx4/Makefile
> +++ b/drivers/net/mlx4/Makefile
> @@ -115,7 +115,7 @@ endif
>  $(LIB_GLUE): mlx4_glue.o
>         $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \
>                 -Wl,-h,$(LIB_GLUE) \
> -               -s -shared -o $@ $< -libverbs -lmlx4
> +               -shared -o $@ $< -libverbs -lmlx4
>
>  mlx4_glue.o: mlx4_autoconf.h
>
>
After IRC discussion I completely agree that this shouldn't be stripped,
thanks for the fix.

Acked-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>

--

2.17.1
>
>

-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd