[dpdk-dev] [PATCH] memory: fix segfault on rte_mem_virt2memseg() call with invalid addr

Burakov, Anatoly anatoly.burakov at intel.com
Fri Jun 1 12:50:12 CEST 2018


On 01-Jun-18 2:22 PM, Dariusz Stojaczyk wrote:
> When trying to use it with an address that's not
> managed by DPDK it would segfault due to a missing
> check. The doc says this function returns either
> a pointer or NULL, so let it do so.
> 
> Change-Id: Ib292f148914e67054f5d7b664077f19cba7000e4
> Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk at intel.com>
> ---

Generally speaking, if the commit is a bugfix, reference to the original 
commit that introduces the issue should be part of the commit message. 
See DPDK contribution guidelines [1] and "git fixline" [2].

[1] http://dpdk.org/doc/guides/contributing/patches.html
[2] http://dpdk.org/dev

Change-Id: is probably a leftover from Gerrit, this shouldn't be part of 
the commit message.

On the substance of the patch itself:

Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>

-- 
Thanks,
Anatoly


More information about the dev mailing list