[dpdk-dev] [PATCH v3 2/2] memalloc: keep in mind a failed MAP_FIXED mmap may still perform an unmap
Burakov, Anatoly
anatoly.burakov at intel.com
Fri Jun 1 17:07:28 CEST 2018
On 01-Jun-18 1:59 PM, Dariusz Stojaczyk wrote:
> This isn't documented in the manuals, but a failed
> mmap(..., MAP_FIXED) may still unmap overlapping
> regions. In such case, we need to remap these regions
> back into our address space to ensure mem contiguity.
> We do it unconditionally now on mmap failure just to
> be safe.
>
> Verified on Linux 4.9.0-4-amd64. I was getting
> ENOMEM when trying to map hugetlbfs with no space
> left, and the previous anonymous mapping was still
> being removed.
>
> Changes from v2:
> * added "git fixline" tags
>
> Changes from v1:
> * checkpatch fixes
> * remapping is now done regardless of the mmap errno
>
> Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime")
> Cc: anatoly.burakov at intel.com
> Cc: stable at dpdk.org
>
> Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk at intel.com>
> ---
Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>
Version changes should not be part of commit message. Thomas, could you
please fix this on apply?
--
Thanks,
Anatoly
More information about the dev
mailing list