[dpdk-dev] [PATCH] ethdev: force RSS offload rules again

[Shahaf Shuler]

Sunday, June 3, 2018 5:15 PM, Ferruh Yigit:
> Subject: Re: [PATCH] ethdev: force RSS offload rules again
> 
> On 6/3/2018 11:41 AM, Shahaf Shuler wrote:
> > Thursday, May 31, 2018 4:23 PM, Ferruh Yigit:
> >> Subject: [PATCH] ethdev: force RSS offload rules again
> >>
> >> PMDs should provide supported RSS hash functions via
> >> dev_info.flow_type_rss_offloads variable.
> >>
> >> There is a check in ethdev if requested RSS hash function is
> >> supported by PMD or not.
> >> This check has been relaxed in previous release to not return an
> >> error when a non supported has function requested [1], this has been
> >> done to not break the applications.
> >>
> >> Adding the error return back.
> >> PMDs need to provide correct list of supported hash functions and
> >> applications need to take care this information before configuring
> >> the RSS otherwise they will get an error from APIs:
> >> rte_eth_dev_rss_hash_update()
> >> rte_eth_dev_configure()
> >
> > Are the current app/examples in DPDK tree behave accordingly?
> 
> I tried a few which were good but I don't know about all.
> 
> That is why we should merge this patch early so that we can detect and fix
> ones fails.

Acked-by: Shahaf Shuler <shahafs at mellanox.com>