[dpdk-dev] [PATCH] net/mvpp2: check pointer before using it

Tomasz Duszynski tdu at semihalf.com
Mon Jun 4 11:24:28 CEST 2018


Avoid NULL dereference by checking pointer before using it.

Note that the fixes tag is before the driver was renamed
to mvpp2, so the patch will not apply that far back.

Fixes: 3588aaa68eab ("net/mrvl: fix HIF objects allocation")

Signed-off-by: Tomasz Duszynski <tdu at semihalf.com>
---
 drivers/net/mvpp2/mrvl_ethdev.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c
index ae8804a..d5eb1fe 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -1614,9 +1614,12 @@ mrvl_rx_queue_release(void *rxq)
 	if (core_id == LCORE_ID_ANY)
 		core_id = 0;

+	if (!q)
+		return;
+
 	hif = mrvl_get_hif(q->priv, core_id);

-	if (!q || !hif)
+	if (!hif)
 		return;

 	tc = q->priv->rxq_map[q->queue_id].tc;
--
2.7.4



More information about the dev mailing list