[dpdk-dev] [PATCH v3 02/27] net/ena: update ena_com to the newer version

Ferruh Yigit ferruh.yigit at intel.com
Fri Jun 8 21:43:07 CEST 2018


On 6/7/2018 10:42 AM, Michal Krawczyk wrote:
> ena_com is the HAL provided by the vendor and it shouldn't be modified
> by the driver developers.
> 
> The PMD and platform file was adjusted for the new version of the
> ena_com:
>     * Do not use deprecated meta descriptor fields
>     * Add empty AENQ handler structure with unimplemented handlers
>     * Add memzone allocations count to ena_ethdev.c file - it was
>       removed from ena_com.c file
>     * Add new macros used in new ena_com files
>     * Use error code ENA_COM_UNSUPPORTED instead of ENA_COM_PERMISSION
> 
> Signed-off-by: Michal Krawczyk <mk at semihalf.com>
> Signed-off-by: Rafal Kozik <rk at semihalf.com>

<...>

> @@ -1840,7 +1844,7 @@ void ena_com_aenq_intr_handler(struct ena_com_dev *dev, void *data)
>  		ena_trc_dbg("AENQ! Group[%x] Syndrom[%x] timestamp: [%llus]\n",
>  			    aenq_common->group,
>  			    aenq_common->syndrom,
> -			    (unsigned long long)aenq_common->timestamp_low +
> +			    (u64)aenq_common->timestamp_low +

This is causing build error [1], please check with DEBUG enabled.

[1]
.../drivers/net/ena/base/ena_com.c:1847:8: error: format specifies type
'unsigned long long' but the argument has type 'unsigned long' [-Werror,-Wformat]
                            (u64)aenq_common->timestamp_low +
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../drivers/net/ena/base/ena_plat_dpdk.h:129:59: note: expanded from macro
'ena_trc_dbg'
        RTE_LOG(DEBUG, PMD, "[ENA_COM: %s] " format, __func__, ##arg)
                                                                 ^~~
.../x86_64-native-linuxapp-clang/include/rte_log.h:322:32: note: expanded from
macro 'RTE_LOG'
                 RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__)
                                             ^~~~~~~~~~~
1 error generated.


More information about the dev mailing list