[dpdk-dev] [PATCH v3 10/27] net/ena: add lrte_timer dependency for linking

[Michał Krawczyk]

2018-06-08 21:17 GMT+02:00 Ferruh Yigit <ferruh.yigit at intel.com>:
> On 6/7/2018 10:43 AM, Michal Krawczyk wrote:
>> ENA PMD is required to use librte_timer. The appropriate depndency must
>> be added ifin case the DPDK will be built as shared library.
>>
>> Signed-off-by: Michal Krawczyk <mk at semihalf.com>
>> ---
>>  drivers/net/ena/Makefile | 1 +
>>  mk/rte.app.mk            | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile
>> index 43339f3b9..ff9ce315b 100644
>> --- a/drivers/net/ena/Makefile
>> +++ b/drivers/net/ena/Makefile
>> @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES)
>>  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>>  LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
>>  LDLIBS += -lrte_bus_pci
>> +LDLIBS += -lrte_timer
>>
>>  include $(RTE_SDK)/mk/rte.lib.mk
>> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
>> index 1e32c83e7..c70bc254e 100644
>> --- a/mk/rte.app.mk
>> +++ b/mk/rte.app.mk
>> @@ -60,6 +60,7 @@ endif
>>
>>  _LDLIBS-y += --whole-archive
>>
>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer
>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_CFGFILE)        += -lrte_cfgfile
>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_HASH)           += -lrte_hash
>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMBER)         += -lrte_member
>
> Instead of being separate patch, this should be part of the patch that starts
> using rte_timer library.
> I guess that is next patch (11/27), if you confirm I can squash this to next
> patch while merging.
>

Ok, that's fine to squash it with that patch.