[dpdk-dev] [PATCH] examples/ip_pipeline: add link show to the cli
Laatz, Kevin
kevin.laatz at intel.com
Fri Jun 15 16:57:04 CEST 2018
Hi Cristian,
> > +
> > + link_list = links_get();
>
> We don't need this function, the lined list of links is a global public object,
> please access it directly.
link_list is declared as a static struct in link.c so it is not accessible from cli.c
I can either leave this function in to pass the pointer to the cli.c or move the declaration to link.h.
Do you have a preference?
> >
> > +struct link_list *
> > +links_get(void)
> > +{
> > + return &link_list;
> > +}
> > +
>
> Function to be removed, used linked list of links directly (see comment
> above).
See above comment
Thanks,
Kevin
More information about the dev
mailing list