[dpdk-dev] [PATCH v1 1/7] compress/octeontx: add octeontx zip PMD support

[Verma, Shally]

Hi Jerin

>-----Original Message-----
>From: Jacob, Jerin
>Sent: 10 June 2018 16:09
>To: Verma, Shally <Shally.Verma at cavium.com>
>Cc: pablo.de.lara.guarch at intel.com; fiona.trahe at intel.com; dev at dpdk.org; Athreya, Narayana Prasad
><NarayanaPrasad.Athreya at cavium.com>; Challa, Mahipal <Mahipal.Challa at cavium.com>; Gupta, Ashish
><Ashish.Gupta at cavium.com>; Sahu, Sunila <Sunila.Sahu at cavium.com>
>Subject: Re: [dpdk-dev] [PATCH v1 1/7] compress/octeontx: add octeontx zip PMD support
>
>-----Original Message-----
>> Date: Tue,  5 Jun 2018 16:05:07 +0530
>> From: Shally Verma <shally.verma at caviumnetworks.com>
>> To: pablo.de.lara.guarch at intel.com
>> CC: fiona.trahe at intel.com, dev at dpdk.org, pathreya at caviumnetworks.com,
>>  mchalla at caviumnetworks.com, Ashish Gupta
>>  <ashish.gupta at caviumnetworks.com>, Sunila Sahu
>>  <sunila.sahu at caviumnetworks.com>
>> Subject: [dpdk-dev] [PATCH v1 1/7] compress/octeontx: add octeontx zip PMD
>>  support
>> X-Mailer: git-send-email 1.9.1
>>
>> Add octeontx zip pmd support in compressdev driver.
>> Add device probe and remove support.
>> Update makefile to build octeontx zip pmd
>>
>> Signed-off-by: Ashish Gupta <ashish.gupta at caviumnetworks.com>
>> Signed-off-by: Shally Verma <shally.verma at caviumnetworks.com>
>> Signed-off-by: Sunila Sahu <sunila.sahu at caviumnetworks.com>
>> ---
>>  config/common_base                                 |   6 +
>>  drivers/compress/Makefile                          |   2 +-
>>  drivers/compress/octeontx/Makefile                 |  33 ++++++
>>  drivers/compress/octeontx/meson.build              |  10 ++
>>  .../octeontx/rte_pmd_octeontx_compress_version.map |   3 +
>>  drivers/compress/octeontx/zip_pmd.c                | 129 +++++++++++++++++++++
>>  drivers/compress/octeontx/zipvf.c                  |  48 ++++++++
>>  drivers/compress/octeontx/zipvf.h                  |  47 ++++++++
>>  usertools/dpdk-devbind.py                          |   9 ++
>>  9 files changed, 286 insertions(+), 1 deletion(-)
>>
>> diff --git a/config/common_base b/config/common_base
>> index 6b0d1cbbb..e56d14b7f 100644
>> --- a/config/common_base
>> +++ b/config/common_base
>> @@ -584,6 +584,12 @@ CONFIG_RTE_COMPRESS_MAX_DEVS=64
>>  #
>>  CONFIG_RTE_COMPRESSDEV_TEST=n
>>
>> +#
>> +# Compile PMD for Octeontx ZIPVF compression device
>> +#
>> +CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF=n
>
>Please enable this option  by default, If there are arm64 specific
>usage then please stub it out so that it can compile on
>all architectures. It will help to verify the API changes
>across the architecture by author.(i.e author should not depend arm64
>box to verify the compilation changes)
>
[Shally] Ok. Will propose this change in next patch

>> +CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF_DEBUG=n
>
>This config option is not required when we are using
>dynamic debugging.

[Shally] Ack

>
>> +
>>  #
>>  # Compile PMD for ISA-L compression device
>>  #
>> diff --git a/drivers/compress/Makefile b/drivers/compress/Makefile
>> index 592497f51..62b4e5abe 100644
>> --- a/drivers/compress/Makefile
>> +++ b/drivers/compress/Makefile
>> @@ -4,5 +4,5 @@
>>  include $(RTE_SDK)/mk/rte.vars.mk
>>
>>  DIRS-$(CONFIG_RTE_LIBRTE_PMD_ISAL) += isal
>> -
>> +DIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF) += octeontx
>>  include $(RTE_SDK)/mk/rte.subdir.mk
>> diff --git a/drivers/compress/octeontx/Makefile b/drivers/compress/octeontx/Makefile
>> new file mode 100644
>> index 000000000..89078f085
>> --- /dev/null
>> +++ b/drivers/compress/octeontx/Makefile
>> @@ -0,0 +1,33 @@
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright(c) 2017-2018 Cavium Network
>
>We are using the following copyright header across DPDK,
>Please use the same schematics new.
>
>example:
>Copyright(c) 2017 Cavium, Inc
>
>

//snip

>
>Use alphabetical order.
>
>> +#include "zipvf.h"
>> +
>> +/* global structure to keep driver info */
>> +struct zip_pmd_private zip_pmd_priv;
>
>Remove global memory. Use name based memzone infrastructure to
>allocate the memory.

[Shally] Ok. Will look into this.

>
//snip

>> +
>> +
>> +#endif /* _RTE_ZIP_VF_H_ */
>> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
>
>Addition to usertools/dpdk-devbind.py, please send it as separate patch as
>it is an common code change

[Shally] Ok.

Thanks for review.
Shally