[dpdk-dev] [PATCH v1 7/7] drivers/compress: add meson.build support

[De Lara Guarch, Pablo]

Hi Shally,

> -----Original Message-----
> From: Verma, Shally [mailto:Shally.Verma at cavium.com]
> Sent: Wednesday, June 20, 2018 7:02 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
> Cc: Trahe, Fiona <fiona.trahe at intel.com>; dev at dpdk.org; Athreya, Narayana
> Prasad <NarayanaPrasad.Athreya at cavium.com>; Challa, Mahipal
> <Mahipal.Challa at cavium.com>; Gupta, Ashish <Ashish.Gupta at cavium.com>;
> Sahu, Sunila <Sunila.Sahu at cavium.com>
> Subject: RE: [PATCH v1 7/7] drivers/compress: add meson.build support
> 
> 
> 
> >-----Original Message-----
> >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch at intel.com]
> >Sent: 20 June 2018 04:00
> >To: Verma, Shally <Shally.Verma at cavium.com>
> >Cc: Trahe, Fiona <fiona.trahe at intel.com>; dev at dpdk.org; Athreya,
> >Narayana Prasad <NarayanaPrasad.Athreya at cavium.com>;
> >Challa, Mahipal <Mahipal.Challa at cavium.com>; Gupta, Ashish
> ><Ashish.Gupta at cavium.com>; Sahu, Sunila <Sunila.Sahu at cavium.com>
> >Subject: RE: [PATCH v1 7/7] drivers/compress: add meson.build support
> >
> >External Email
> >
> >> -----Original Message-----
> >> From: Shally Verma [mailto:shally.verma at caviumnetworks.com]
> >> Sent: Tuesday, June 5, 2018 11:35 AM
> >> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
> >> Cc: Trahe, Fiona <fiona.trahe at intel.com>; dev at dpdk.org;
> >> pathreya at caviumnetworks.com; mchalla at caviumnetworks.com; Ashish
> Gupta
> >> <ashish.gupta at caviumnetworks.com>; Sunila Sahu
> >> <sunila.sahu at caviumnetworks.com>
> >> Subject: [PATCH v1 7/7] drivers/compress: add meson.build support
> >>
> >> Add octeontx in drivers/compress/meson.build.
> >
> >This should be added in patch 1.
> >
> >>
> >> Also change the config and drv format flags to append _compress to
> >> use compression specific format for global filenames. This also
> >> require change in compression PMDs to rename their version.map files
> >> as rte_pmd_<pmd
> >> name>_compress.map ex. Isal should rename as
> >> rte_pmd_isal_compress_version.map.
> >>
> >> Currently the drivers/compress/meson.build use the generic config
> >> names with no compress specific specifier. This breaks meson build
> >> when vendor uses same name for different PMDs, where all belongs to same
> platform.
> >> Ex. drivers/net/octeontx, drivers/event/octeontx,
> >> drivers/compress/octeontx where, net, event and compress carry PMD
> >> for eth, event and compression devices for Octeontx platform. Thus,
> >> differentiate globally used files using module specific specifier ex.
> >> rte_pmd_octeontx_compress_version.map
> >> and rte_pmd_octeontx_event_version.map
> >
> >I think instead of forcing all the PMDs to use that suffix, if there
> >are drivers with the same PMD, they can add the "compres" suffix, without
> imposing it to others.
> >
> [Shally] Meson build force us to use then directory name as octeontx_compress
> where as we want to keep it as compress/octeontx (on the similar lines of
> net/octeontx, event/octeontx). Also its already under compress, so having it as
> compress/octeontx_compress looks unnecessary,

For null crypto, the directory is called crypto/null and it is built with meson (and there is also a net/null).
Maybe doing something like that will work?

If it doesn't, then you can add this, but make sure that you fix
the isal export map name in the Makefile too.

Thanks,
Pablo

> 
> Thanks
> Shally