[dpdk-dev] [PATCH v5 1/2] net/tap: calculate checksums of multi segs packets

Wiles, Keith keith.wiles at intel.com
Sun Jun 24 15:45:18 CEST 2018



> On Jun 23, 2018, at 6:17 PM, Ophir Munk <ophirmu at mellanox.com> wrote:
> 
> Prior to this commit IP/UDP/TCP checksum offload calculations
> were skipped in case of a multi segments packet.
> This commit enables TAP checksum calculations for multi segments
> packets.
> The only restriction is that the first segment must contain
> headers of layers 3 (IP) and 4 (UDP or TCP)
> 
> Reviewed-by: Raslan Darawsheh <rasland at mellanox.com>
> Signed-off-by: Ophir Munk <ophirmu at mellanox.com>
>
Looks good. Still could have had a few more blank lines IMHO :-)

Acked-by: Keith Wiles <keith.wiles at intel.com> for Series

Regards,
Keith



More information about the dev mailing list