[dpdk-dev] [PATCH] crypto/aesni_mb: add dynamic logging to aesni_mb

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Wed Jun 27 16:56:52 CEST 2018


Hi Naga,

> -----Original Message-----
> From: Somarowthu, Naga SureshX
> Sent: Tuesday, June 12, 2018 7:24 AM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Pattan, Reshma
> <reshma.pattan at intel.com>; Somarowthu, Naga SureshX
> <naga.sureshx.somarowthu at intel.com>
> Subject: [PATCH] crypto/aesni_mb: add dynamic logging to aesni_mb
> 
> From: Naga Suresh Somarowthu <naga.sureshx.somarowthu at intel.com>
> 
> 1.added new logtype for aesni_mb driver.
> 2.registered new logtype.
> 3.MB_LOG_ERR and CDEV_LOG_ERR are
> replaced with new logtype name AESNI_MB_PMD_LOG.
> 
> Signed-off-by: Naga Suresh Somarowthu
> <naga.sureshx.somarowthu at intel.com>
> Reviewed-by: Reshma Pattan <reshma.pattan at intel.com>

Could you make the following changes?

- Change the macro to AESNI_MB_LOG, to make it shorter.
- Change title to: crypto/aesni_mb: add dynamic logging
- Remove unused "CONFIG_RTE_LIBRTE_PMD_AESNI_MB_DEBUG=n"
from config file.
- Set log level of the new type to INFO (see isal_compress_pmd.c)

Thanks,
Pablo


More information about the dev mailing list