[dpdk-dev] [PATCH 05/31] net/bnxt: fix dev close operation
Ajit Khaparde
ajit.khaparde at broadcom.com
Thu Jun 28 22:16:23 CEST 2018
>
> > + PMD_DRV_LOG(INFO, "Calling Device uninit\n");
>
> This looks like can be a debug message, what do you think?
>
Yes. Changed it to debug.
>
> <...>
>
> > @@ -3456,7 +3469,7 @@ static int bnxt_pci_remove(struct rte_pci_device
> *pci_dev)
> > static struct rte_pci_driver bnxt_rte_pmd = {
> > .id_table = bnxt_pci_id_map,
> > .drv_flags = RTE_PCI_DRV_NEED_MAPPING |
> > - RTE_PCI_DRV_INTR_LSC,
> > + RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV,
>
> Is Remove interrupts really supported? I can't find the related code in
> the driver.
>
That was some left over code. I cleaned it up.
Thanks
>
> You need to call _rte_eth_dev_callback_process() for
> RTE_ETH_EVENT_INTR_RMV
> where you handle the interrupt.
>
> And announce the feature "Removal event" in bnxt.ini
More information about the dev
mailing list