[dpdk-dev] [PATCH] net/bonding: set dev_started later

Chas Williams 3chas3 at gmail.com
Fri Mar 16 17:34:41 CET 2018


From: "Charles (Chas) Williams" <chas3 at att.com>

There are several error paths where the bonding device may not start.
Don't set dev_started until we know that we are sure start is going
to succeed.

Fixes: 2efb58cbab ("bond: new link bonding library")
Cc: stable at dpdk.org

Signed-off-by: Chas Williams <chas3 at att.com>
---
 drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index b59ba9f7c..6d738f8c2 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -2028,7 +2028,6 @@ bond_ethdev_start(struct rte_eth_dev *eth_dev)
 	}
 
 	eth_dev->data->dev_link.link_status = ETH_LINK_DOWN;
-	eth_dev->data->dev_started = 1;
 
 	internals = eth_dev->data->dev_private;
 
@@ -2089,6 +2088,9 @@ bond_ethdev_start(struct rte_eth_dev *eth_dev)
 		if (internals->slaves[i].link_status_poll_enabled)
 			internals->link_status_polling_enabled = 1;
 	}
+
+	eth_dev->data->dev_started = 1;
+
 	/* start polling if needed */
 	if (internals->link_status_polling_enabled) {
 		rte_eal_alarm_set(
-- 
2.13.6



More information about the dev mailing list