[dpdk-dev] [PATCH v5] ethdev: return named opaque type instead of void pointer
Neil Horman
nhorman at tuxdriver.com
Wed Mar 21 14:04:01 CET 2018
On Tue, Mar 20, 2018 at 04:34:04PM +0000, Ferruh Yigit wrote:
> "struct rte_eth_rxtx_callback" is defined as internal data structure and
> used as named opaque type.
>
> So the functions that are adding callbacks can return objects in this
> type instead of void pointer.
>
> Also const qualifier added to "struct rte_eth_rxtx_callback *" to
> protect it better from application modification.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---
> v2:
> * keep using struct * in parameters, instead add callback functions
> return struct rte_eth_rxtx_callback pointer.
>
> v4:
> * Remove deprecation notice. LIBABIVER already increased in this release
>
> v5:
> * add const qualifier to rte_eth_rxtx_callback
I still wish we could find a way to remove the inline functions and truly
protect that struct, but a const is definately better than nothing
Acked-by: Neil Horman <nhorman at tuxdriver.com>
More information about the dev
mailing list