[dpdk-dev] [PATCH 1/2] net/mlx5: enforce RSS key length limitation

Shahaf Shuler shahafs at mellanox.com
Tue Mar 27 07:55:32 CEST 2018


Monday, March 26, 2018 2:18 PM, Nélio Laranjeiro:
> On Mon, Mar 26, 2018 at 01:12:18PM +0300, Shahaf Shuler wrote:
> > @@ -48,6 +48,13 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev,
> >  		return -rte_errno;
> >  	}
> >  	if (rss_conf->rss_key && rss_conf->rss_key_len) {
> > +		if (rss_conf->rss_key_len != rss_hash_default_key_len) {
> > +			DRV_LOG(ERR,
> > +				"port %u RSS key len must be %zu Bytes
> long",
> > +				dev->data->port_id,
> rss_hash_default_key_len);
> > +			rte_errno = ENOTSUP;
> 
> Should be EINVAL when values are incorrect.

OK.

Considering it is the only comment in this series, are you OK with me changing it while applying to next-net-mlx? 

> 
> > +			return -rte_errno;
> > +		}
> >  		priv->rss_conf.rss_key = rte_realloc(priv->rss_conf.rss_key,
> >  						     rss_conf->rss_key_len, 0);
> >  		if (!priv->rss_conf.rss_key) {
> > --
> > 2.12.0
> 
> Thanks,
> 
> --
> Nélio Laranjeiro
> 6WIND


More information about the dev mailing list