[dpdk-dev] [PATCH v3 1/4] net/virtio: fix add pointer checking
Tan, Jianfeng
jianfeng.tan at intel.com
Wed Mar 28 09:26:14 CEST 2018
On 3/21/2018 11:03 AM, zhiyong.yang at intel.com wrote:
> It is necessary to add pointer checking because in some case the
> code will cause crash. For example, the code goes here before
> memory allocation of rxvq is finished.
>
> Fixes: 7365504f77e3("net/virtio: support guest announce")
> Cc: stable at dpdk.org
> Signed-off-by: Zhiyong Yang <zhiyong.yang at intel.com>
This fix is not related to the topic of this patch series, correct?
Maybe next time, we can put it out of the patch series.
Reviewed-by: Jianfeng Tan <jianfeng.tan at intel.com>
Thanks,
Jianfeng
> ---
> drivers/net/virtio/virtio_ethdev.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index 884f74ad0..f377d8aa3 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1273,9 +1273,13 @@ static void
> virtio_notify_peers(struct rte_eth_dev *dev)
> {
> struct virtio_hw *hw = dev->data->dev_private;
> - struct virtnet_rx *rxvq = dev->data->rx_queues[0];
> + struct virtnet_rx *rxvq;
> struct rte_mbuf *rarp_mbuf;
>
> + if (!dev->data->rx_queues)
> + return;
> +
> + rxvq = dev->data->rx_queues[0];
> rarp_mbuf = rte_net_make_rarp_packet(rxvq->mpool,
> (struct ether_addr *)hw->mac_addr);
> if (rarp_mbuf == NULL) {
More information about the dev
mailing list