[dpdk-dev] [PATCH v3] net/vhost: fix segfault when creating vdev dynamically

Yang, Zhiyong zhiyong.yang at intel.com
Fri Mar 30 09:32:34 CEST 2018


Hi Maxime, Junjie,

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Junjie Chen
> Sent: Friday, March 30, 2018 2:59 PM
> To: Tan, Jianfeng <jianfeng.tan at intel.com>; maxime.coquelin at redhat.com;
> mtetsuyah at gmail.com
> Cc: dev at dpdk.org; Chen, Junjie J <junjie.j.chen at intel.com>;
> Chen at dpdk.org
> Subject: [dpdk-dev] [PATCH v3] net/vhost: fix segfault when creating vdev
> dynamically
> 
> When creating vdev dynamically, vhost pmd driver starts directly without
> checking TX/RX queues are ready or not, and thus causes segmentation fault
> when vhost library accesses queues. This patch adds a flag to check whether
> queues are setup or not, and adds queues setup into dev_start function to
> allow user to start them after setting up.
> 
> Fixes: aed0b12930b3 ("net/vhost: fix socket file deleted on stop")
> Signed-off-by: Chen, Junjie <junjie.j.chen at intel.com>
> ---

Thanks for Junjie's patch!

I also came across the similar issue when developing virtio-user server mode.
>From user's perspective, the patch can fix the issue in my user case instead of 
the patch http://www.dpdk.org/dev/patchwork/patch/36340/

Tested-by: Zhiyong Yang <zhiyong.yang at intel.com>

Thanks
Zhiyong



More information about the dev mailing list